omise / omise-woocommerce

Omise WooCommerce Plugin
https://docs.opn.ooo/woocommerce-plugin
MIT License
47 stars 27 forks source link

[ENGA3-453]: Fetching the keys from the user entered #311

Closed aashishgurung closed 2 years ago

aashishgurung commented 2 years ago

1. Objective

Fix the issue of user unable to set new keys when their old keys are expired.

Jira Ticket: #453

2. Description of change

We have many classes that calls capabilities API before the user entered keys are saved. This means they will use the old saved keys instead of new user entered keys. This will cause issues like:

To avoid such issue we first get the user entered keys from $_POST so that other classes calls the capabilities API from the user entered keys.

3. Quality assurance

🔧 Environments:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication