search

omise / omise-woocommerce

Omise WooCommerce Plugin
https://docs.opn.ooo/woocommerce-plugin
MIT License
47 stars 27 forks source link

[ENGA3-518]: Fix the issue of customer getting back to checkout page from OTP page. #323

Closed aashishgurung closed 2 years ago

aashishgurung commented 2 years ago

1. Objective

Fix the issue of customer getting back to checkout page from OTP page.

Jira Ticket: #518

2. Description of change

There was no way of reproducing this issue in staging and for production, we don't have live credit card. Our only option was to scan the code.

We assume that the includes/class-omise-callback.php return customer to the checkout page because plugin thought the redirect URL was triggered by user. The reason should be the headers we rely on had a differently value. Previously, we added token in redirect URL for mobile banking only.

To fix this we added token in the return URL for all remaining payment methods except offline and OCBC PAO. After this change, we rely on headers for OCBC PAO only because for some reason we can send query params in redirect URL for OCBC PAO.

3. Quality assurance

Using test account of staging environment, test the following payment methods. Success and failure should redirect to appropriate page.

Thailand

Malaysia

Singapore

🔧 Environments:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

No Coverage information No Coverage information
27.6% 27.6% Duplication