Bug Fixed not compatible with country based payments plugin

omise / omise-woocommerce

Omise WooCommerce Plugin

https://docs.opn.ooo/woocommerce-plugin

MIT License

47 stars 27 forks source link

Bug Fixed not compatible with country based payments plugin #379

Closed ajzkk closed 1 year ago

ajzkk commented 1 year ago

1. Objective

Bug Fixed not compatible with country based payments plugin

2. Description of change

Country based payments plugin remove the the whole html element of omise card payment, if user not selected the country in shipping address.

3. Quality assurance

Tested locally with

For first time user
Tested with normal user
Tested with guest user

4. Impact of the change

N/A

5. Priority of change

Normal

aashishgurung commented 1 year ago

Can you add more description about how other plugins removed code from our plugin? How does this change prevents that?

ajzkk commented 1 year ago

Can you add more description about how other plugins removed code from our plugin? How does this change prevents that?

I do not know how their plugin work, but I can visually see in checkout page that card payment is missing, and also if you try to inspect, you will see card payment element is missing until user select the country. So I check with the element. If element is missing, then do not run showOmiseEmbeddedCardForm