omise / omise-woocommerce

Omise WooCommerce Plugin
https://docs.opn.ooo/woocommerce-plugin
MIT License
47 stars 27 forks source link

Fixed Japanese translation issue in secure form. #389

Closed aashishgurung closed 1 year ago

aashishgurung commented 1 year ago

1. Objective

Fix Japanese translation issue in secure form.

2. Description of change

We removed the localMatching array which was not necessary. because we get the required value from the LOCALE.

Screenshot 2566-08-03 at 15 52 04

3. Quality assurance

Specify where and how you tested this and what further testing it might need.

🔧 Environments:

danfowler commented 1 year ago

@aashishgurung no tests?

aashishgurung commented 1 year ago

@danfowler We discussed that writing test cases for our current JS implementation is challenging and decided to not include them. That's why our sonar cloud setup also excludes JS.