search

omissis / go-jsonschema

A tool to generate Go data types from JSON Schema definitions.
MIT License
563 stars 90 forks source link

fix: support for yaml file references #179

Closed johanneswuerbach closed 8 months ago

johanneswuerbach commented 9 months ago

https://github.com/omissis/go-jsonschema/pull/153 broke the support for yaml references.

This PR fixes it and adds a tests.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@2cee873). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ======================================= Coverage ? 76.16% ======================================= Files ? 24 Lines ? 1867 Branches ? 0 ======================================= Hits ? 1422 Misses ? 355 Partials ? 90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

omissis commented 9 months ago

hey @johanneswuerbach , thanks for the PR, I will check it as soon as I can (probably during the xmas holidays) 🙏

johanneswuerbach commented 8 months ago

@omissis any chance we could get a new release with this PR and the latest main?

omissis commented 8 months ago

@johanneswuerbach I guess that could be done :)

omissis commented 8 months ago

@johanneswuerbach et voilà, fresh out of the oven -> https://github.com/omissis/go-jsonschema/releases/tag/v0.15.0