add support for additionalProperties when other fields exist

omissis / go-jsonschema

A tool to generate Go data types from JSON Schema definitions.

MIT License

584 stars 94 forks source link

add support for additionalProperties when other fields exist #189

Closed codeboten closed 6 months ago

codeboten commented 9 months ago

This is a proposed implementation to address the feature requested in #188. Tests still need fixing, but I want to get support on the implementation first.

Please offer alternatives, i'm new to this code, so opinions/suggestions are more than welcome.

omissis commented 9 months ago

hey @codeboten ! thanks for taking the time to propose this improvement 🤗 I will try to look at it in the next few days 🙌

omissis commented 6 months ago

hi @codeboten, thanks for your contribution! I opened a new PR (#218), and finished the implementation, mostly adding tests and handling some edge cases. I marked you as co-author, I hope GH will attribute it correctly :) Closing this one.