search

omissis / go-jsonschema

A tool to generate Go data types from JSON Schema definitions.
MIT License
558 stars 89 forks source link

Removes nil check for `required` properties #215

Closed Henkoglobin closed 4 months ago

Henkoglobin commented 4 months ago

This fixes #97, bringing go-jsonschema's behavior in line with 6.5.3 of the JSON Schema Validation Spec. See the linked issue for details and an example.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 39.53488% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (d963216) to head (2d87019). Report is 10 commits behind head on main.

Files Patch % Lines
...data/validation/requiredFields/requiredNullable.go 50.00% 7 Missing and 7 partials :warning:
...s/data/validation/requiredFields/requiredFields.go 0.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== - Coverage 76.58% 74.90% -1.68% ========================================== Files 24 26 +2 Lines 1892 1602 -290 ========================================== - Hits 1449 1200 -249 + Misses 354 306 -48 - Partials 89 96 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

omissis commented 4 months ago

hey @Henkoglobin thanks for sending in this PR! I will try to review it this weekend and merge it :)