search

omkarcloud / botasaurus

The All in One Framework to build Awesome Scrapers.
https://www.omkar.cloud/botasaurus/
MIT License
1.14k stars 103 forks source link

Add support for SOCKS proxies #113

Closed raunaqss closed 1 month ago

raunaqss commented 1 month ago

Hi there,

Sorry for creating another feature request. I think it would improve the usability and so just adding here. In my experience socks proxies are faster than http proxies so it would be great if you could add support for them as well.

Currently, when I try to use them I get the following message:

javascript.errors.JavaScriptError: ('anonymizeProxy', 'Error: Invalid "proxyUrl" option: only HTTP proxies are currently supported.\n at Object.anonymizeProxy (/path/venv/lib/python3.10/site-packages/javascript/js/node_modules/proxy-chain/dist/anonymize_proxy.js:28:15)\n at Bridge.call (/path/venv/lib/python3.10/site-packages/javascript/js/bridge.js:136:42)\n at Bridge.onMessage (/path/venv/lib/python3.10/site-packages/javascript/js/bridge.js:231:25)\n at Socket.<anonymous> (/path/venv/lib/python3.10/site-packages/javascript/js/bridge.js:288:18)\n at Socket.emit (events.js:400:28)\n at addChunk (internal/streams/readable.js:293:12)\n at readableAddChunk (internal/streams/readable.js:267:9)\n at Socket.Readable.push (internal/streams/readable.js:206:10)\n at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)')

Chetan11-dev commented 1 month ago

We actually use proxy-chain, because proxy-chain does not support socks, so the only option is to go with HTTP proxies. And Thank you very much for starring us, and creating GitHub Issues. I really means a lot to me.