search

omkarcloud / botasaurus

The All in One Framework to build Awesome Scrapers.
https://www.omkar.cloud/botasaurus/
MIT License
1.16k stars 104 forks source link

Update get_chrome_version.py #19

Closed Allamaris0 closed 7 months ago

Allamaris0 commented 7 months ago

Added LOCALAPPDATA path to locate Chrome

Chetan11-dev commented 7 months ago

Hi, is the current script unable to detect chrome and this pull request fixes it?

Allamaris0 commented 7 months ago

Hi, is the current script unable to detect chrome and this pull request fixes it?

The original code assumes that Google Chrome home is in C:\Program Files\Google\Chrome\Application or C:\Program Files (x86)\Google\Chrome\Application but my chrome.exe is located in AppData\Local\Google\Chrome\Application". However I wrote it at night, so it's not super pythonic way 😅 You can also add the code which will search all folders to find chrome home but I guess that those three locations are the most likely.

Chetan11-dev commented 7 months ago

Hi Emilia, Thanks for the pull request! Your contribution is valued and helps improve the project. Great work!