omkarcloud / botasaurus

The All in One Framework to build Awesome Scrapers.
https://www.omkar.cloud/botasaurus/
MIT License
1.18k stars 107 forks source link

Add available drivers to parallel function #8

Closed SantiagoAndre closed 1 year ago

SantiagoAndre commented 1 year ago

Hi there, this is a nice framework, I suggest this small change to allow the reuse of opened drivers in parallel tasks,

Here there is an example of how to use it

driver.sleep(1)
skip_if_less_than = 12
divided_list = divide_list(links, ns, skip_if_less_than)
result = self.parallel(self.save_google, divided_list, len(divided_list),available_drivers=[driver])

I have one driver and I send it to use in one of the parallel tasks

Chetan11-dev commented 1 year ago

First and foremost, thanks for the time and effort that you've put in this pull request. As it stands now, I don't want to merge it because I don't perceive a substantial benefit.

Please don't interpret this as a dismissal of your efforts.

In future endeavors, I kindly request that you initiate a discussion before creating a pull request. This will allow us to assess the need for the proposed changes before any substantial work is undertaken.

I trust that you'll understand my position in this regard. Thank you once again for your dedication and contribution.