search

omnetpp / cmake

CMake module for OMNeT++ projects
GNU General Public License v2.0
8 stars 5 forks source link

rename OMNet.cmake #3

Closed riebl closed 3 years ago

riebl commented 3 years ago

I think the file name OMNet.cmake is unfortunate with its lowercase t. My proposal is OppHelpers.cmake because CMake itself ships modules ending with *Helpers.cmake. Other suggestions are welcome.

Besides the naming, I have reordered the included files alphabetically.

HpLightcorner commented 3 years ago

Sounds good. However, is Opp really unique and not ambiguous? To make sure we won't conflict with others.

riebl commented 3 years ago

I think opp and omnetpp are the two viable options: Former is the prefix of the OMNeT++ executables, latter the C++ namespace and name of the GitHub organisation. That said, OmnetppHelpers works for me equally well.

HpLightcorner commented 3 years ago

I then somehow prefer OmnetppHelpers as being a bit more explicit.

thor commented 3 years ago

I then somehow prefer OmnetppHelpers as being a bit more explicit.

Supported; being explicit is nice.