fbdev: this is NOT a proper role, is an address. We need to remove that role, and either create a proper role and use that address for another role.
netman.Operator : we need to move this role to eoa package. either use existing or create a new one.
Admin : We have 4 different admin roles, but they all use the same address. Maybe we should just reduce this to a single role, or create multiple addresses.
Thresholds : We need to review the thresholds. I’m not sure they make sense.
saneMax: I added a sanemax=5ETH limit for now, to prevent any mishaps or bugs draining wallets.
github action: we need to create a github action to trigger the FundEOAAccounts logic.
monitoring: We need to refactor the monitor/accounts/monitor,go logic to use eoa.AllAccounts. We need to add a metric: monitor_account_balance_low=1 or 0 if the balance we checked is below MinBalance. We should add an low prio alert for this.
`Testing : we need to test this and tune it so it is perfect and working correctly.
corverroos
commented
2 days ago
Some things still TODO:
fbdev: this is NOT a proper role, is an address. We need to remove that role, and either create a proper role and use that address for another role.netman.Operator: we need to move this role to eoa package. either use existing or create a new one.Admin: We have 4 different admin roles, but they all use the same address. Maybe we should just reduce this to a single role, or create multiple addresses.Thresholds: We need to review the thresholds. I’m not sure they make sense.saneMax: I added a sanemax=5ETH limit for now, to prevent any mishaps or bugs draining wallets.FundEOAAccountslogic.monitor/accounts/monitor,gologic to useeoa.AllAccounts. We need to add a metric:monitor_account_balance_low=1 or 0if the balance we checked is belowMinBalance. We should add an low prio alert for this.