Closed nkrishnaswami closed 4 months ago
Hmm, seeing errors on pydantic < 2.6; how far back do you need to support?
Hmm, seeing errors on pydantic < 2.6; how far back do you need to support?
Sorted this out for 2.0+, but I am not sure how to set up the Pydantic v1 test environment
For the moment, I see that there is a test failing in
test-py310-pydantic-v1
. ... Please make sure that the test passes because there is no plan yet to drop support for pydantic v1.
@mauvilsa Gotcha. I was having trouble running the tests in my virtual env, but I found the commands to use in the circleci config; I'll get this fixed shortly!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
9906794
) to head (7ab0c80
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mauvilsa Gotcha. I was having trouble running the tests in my virtual env, but I found the commands to use in the circleci config; I'll get this fixed shortly!
You don't need to look at the circleci config to figure out how to run tests. In the CONTRIBUTING.rst guideline it is recommended that you setup pre-commit. And the pydantic v1 tests are run as part of the pre-push hooks. Also there it is explained how to manually run them.
@mauvilsa got the tests and CI passing! Thanks!
It is looking good. But some work is needed. See the comments.
Thanks for the feedback! I believe I have address these in the latest commit(s).
That last set of fixes broke nested dataclasses on 3.12, and init=False
on 3.7 for Pydantic dataclasses. (The version dependency is a surprise). I'll take a look at those tonight (UTC-5)
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
What does this PR do?
This PR includes a few small, related fixes for non-stdlib (possibly annotated) dataclasses and 3.12-style type aliases:
attrs
class instantiation.Annotated
types where needed.TypeAliasType
where needed. (This and the prior are commonly used with FastAPI)Before submitting