Fix custom instantiators not working for nested dependency injection

omni-us / jsonargparse

Implement minimal boilerplate CLIs derived from type hints and parse from command line, config files and environment variables

https://jsonargparse.readthedocs.io

MIT License

326 stars 49 forks source link

Fix custom instantiators not working for nested dependency injection #608

Closed mauvilsa closed 3 weeks ago

mauvilsa commented 3 weeks ago

What does this PR do?

Fixes #606

Before submitting

[x] Did you read the contributing guideline?
[n/a] Did you update the documentation? (readme and public docstrings)
[x] Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
[x] Did you verify that new and existing tests pass locally?
[x] Did you make sure that all changes preserve backward compatibility?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0dd8ea8) to head (480c8bd). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #608 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 6481 6485 +4 ========================================= + Hits 6481 6485 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.