omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

Add support erc20-to-erc20 mode #135

Closed patitonar closed 6 years ago

patitonar commented 6 years ago
igorbarinov commented 6 years ago

Deploy preview for kind-kilby-95344f processing.

Built with commit 17416c90dd83e18e17d6f6e72a680c063e0a0a14

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5b80191f82d3f13ed9fd1a09

rstormsf commented 6 years ago

great. I will test it out

akolotov commented 6 years ago

Netlify build failed:

10:13:51 PM: > react-app-rewired build
10:13:52 PM: Creating an optimized production build...
10:13:58 PM: Failed to compile.
10:13:58 PM: Module not found: Error: Can't resolve '../contracts/HomeBridgeErcToErc' in '/opt/build/repo/src/stores'
patitonar commented 6 years ago

I think the failed build is not related to the changes. It looks like in this build Netlify is using cached node modules because package.json wasn't modified so npm install wasn't executed, so post-install script to build the contracts didn't execute neither. Let's wait for CI build, if it runs ok, I think we can address Netlify problem on a separate issue

patitonar commented 6 years ago

@akolotov Fixed the issue with Netlify, updated build step to compile contracts as first step.

akolotov commented 6 years ago

Please merge this PR if no other changes is planned to do under it