search

omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

Metamask detection problem #161

Closed rstormsf closed 5 years ago

rstormsf commented 5 years ago

image 2018-12-18 12 17 36

Metamask 5.2.2

rstormsf commented 5 years ago

image

Production version doesn't align with master branch. I don't see same source code such as ethereum.enable() EIP1102 https://github.com/poanetwork/bridge-ui/blob/master/src/stores/utils/web3.js#L15

akolotov commented 5 years ago

@rstormsf thanks! Right, the changes made for https://github.com/poanetwork/bridge-ui/issues/139 were not backported to the old version to the Bridge UI.

akolotov commented 5 years ago

The suggestion is to do the following:

  1. Create two branches: master-1.x and develop-1.x based on https://github.com/poanetwork/bridge-ui/commit/9651de42bb96502d0a5498b0ac5b2dec12762521. The branch develop-1.x will be used for collecting and soaking backports and security updates. The branch master-1.x will be used for changes that need to go to https://bridge.poa.net (netlify auto deploy will be linked with this branch).
  2. Prepare a backport for #139 into develop-1.x. Link the branch develop-1.x with demo POA bridge in the Sokol network.
  3. As soon as everything is tested in develop-1.x merge the changes to master-1.x and produce the new release.
rstormsf commented 5 years ago

@igorbarinov the bug is valid. the bridge was not working.

akolotov commented 5 years ago

Addressed in #162