search

omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

breaking change in last web3js release. fix dep. #180

Closed branciard closed 5 years ago

branciard commented 5 years ago

Last webjs introduce breaking change on existing code.

For instance, v1.0.0-beta.38 remove utils here : https://github.com/ethereum/web3.js/commit/cfd9130e544812e61b10cf1007a9cd1f0d9ec9ad

and it breaks the following code : https://github.com/poanetwork/bridge-ui/blob/develop/src/stores/utils/gas.js#L1

It seems, I have also have an issue with .call format change here from a string to an object and break the switch condition here : https://github.com/poanetwork/bridge-ui/blob/develop/src/stores/utils/bridgeMode.js#L33 as value bridgeModeHash show in the picture :

formatchange

I fix by targeting strict version : "web3": "1.0.0-beta.30" instead of : "web3": "^1.0.0-beta.30".

Maybe a specific future web3js update to treat.

netlify[bot] commented 5 years ago

Deploy preview for kind-kilby-95344f processing.

Building with commit a49de4920acbf8dd7a648b3d1ed2f15ea2a0035a

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c4f19a4979f000008a5d1ab