omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

Fix displayed information for contracts upgraded from v1 to v2 #184

Closed patitonar closed 5 years ago

patitonar commented 5 years ago

This PR fixes the issues mentioned on https://github.com/poanetwork/poa-bridge-contracts/issues/137#issuecomment-461578462

netlify[bot] commented 5 years ago

Deploy preview for kind-kilby-95344f processing.

Building with commit 787c17a312439bedfec215f419924030bf05e9ef

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5cc2f818071909000b411093

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 466


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/ForeignStore.js 0 1 0.0%
src/stores/utils/contract.js 23 37 62.16%
src/stores/HomeStore.js 0 18 0.0%
<!-- Total: 23 56 41.07% -->
Files with Coverage Reduction New Missed Lines %
src/stores/HomeStore.js 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 446: 1.9%
Covered Lines: 96
Relevant Lines: 1393

💛 - Coveralls
patitonar commented 5 years ago

I made some improvements on the solution:

In both solutions deployedAtBlock is used as fromBlock parameter to get the events

akolotov commented 5 years ago

I made some improvements on the solution:

@patitonar thanks. Sorry that I did not notice your initial responses earlier. Now I provided my comments. It could affect your recent changes. Let's discuss this in Slack if it necessary.