search

omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

add AlphaWallet as a supporting wallet for xDAI #186

Closed bitcoinwarrior1 closed 5 years ago

bitcoinwarrior1 commented 5 years ago

For #185

netlify[bot] commented 5 years ago

Deploy preview for kind-kilby-95344f processing.

Building with commit 8d1be1b96dd3fbf3af9e717c207e1010a448551f

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c73e5ac2fff59000834816c

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 340

Totals Coverage Status
Change from base Build 339: 0.0%
Covered Lines: 46
Relevant Lines: 1090
💛 - Coveralls
bitcoinwarrior1 commented 5 years ago

@patitonar fixed, @akolotov where do you mean? For download links we should have both since then you have support for desktop, iOS and android :)

patitonar commented 5 years ago

I think what @akolotov means is that instead of having two buttons for AlphaWallet (one for iOS and one for Android) we should have only one that links to https://alphawallet.com/. If we do that, I think we should update the description (please install one (AlphaWallet, Metamask or Nifty Wallet)) to be more clear that Metamask and Nifty Wallet should be installed for browser and AlphaWallet for iOS and Android. What do you think @James-Sangalli ?

bitcoinwarrior1 commented 5 years ago

@patitonar ok but for the page which says you have no wallet, would you agree that putting the direct download links for an iOS, android and desktop client is best? Would rather the user could get the download promptly rather than searching the website first.

Agree it would be a good idea to mention in the readme which is desktop and which is mobile :)

patitonar commented 5 years ago

@James-Sangalli The current links on Metamask and Nifty wallet buttons doesn't link to their download site, but to a site with instructions on how to download (on different browsers as Chrome and Firefox) and getting started with the wallet. (Actually I just notice that links are broken, but they should be something like https://forum.poa.network/t/nifty-wallet-guide/1789 and https://forum.poa.network/t/wallet-metamask-extension/1819)

I think we should continue with this behavior and so have only one button for AlphaWallet that links to the website or an specific page with instructions for the user to download the app on their platform.

That this makes sense?

akolotov commented 5 years ago

@James-Sangalli I agree with @patitonar in order to keep better user experience and consistency

  1. We provide one link per wallet regardless of the platform.
  2. The link to the instructions how to install and configure the wallet is more preferable since it allows to present how exactly it will address the user's needs.
bitcoinwarrior1 commented 5 years ago

Ok @akolotov & @patitonar as you wish, I have changed the commit to only use one link which will send the user to a page providing some info and links to download or go to the website. Please merge when you can.

bitcoinwarrior1 commented 5 years ago

Done.