Closed gabitoesmiapodo closed 5 years ago
Deploy preview for kind-kilby-95344f processing.
Building with commit 765d9e13545757be8017c9f1ae01e51172620a0f
https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c92707204f6bb00071fd00a
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/components/BridgeAddress.js | 0 | 1 | 0.0% | ||
src/components/BridgeNetwork.js | 0 | 1 | 0.0% | ||
src/components/Disclaimer.js | 0 | 1 | 0.0% | ||
src/components/NoWallet.js | 0 | 1 | 0.0% | ||
src/components/Wallet.js | 0 | 1 | 0.0% | ||
src/components/events/Event.js | 0 | 1 | 0.0% | ||
src/components/Footer.js | 0 | 3 | 0.0% | ||
src/components/NetworkDetails.js | 0 | 3 | 0.0% | ||
src/components/StatusPage.js | 0 | 3 | 0.0% | ||
src/components/icons/CopyIcon.js | 0 | 3 | 0.0% | ||
<!-- | Total: | 2 | 106 | 1.89% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/components/StatisticsPage.js | 1 | 0.0% | ||
src/components/Header.js | 1 | 0.0% | ||
src/components/Loading.js | 1 | 0.0% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 348: | -0.3% |
Covered Lines: | 73 |
Relevant Lines: | 1146 |
Good Job @gabitoesmiapodo ! Please check if you are OK with changes on https://github.com/poanetwork/bridge-ui/pull/192/commits/765d9e13545757be8017c9f1ae01e51172620a0f I added a script to allow us to select the theme from a environmental variable from the .env
file. As default it will use current core theme, if you specify APP_STYLES=classic
it will use the new Ethereum Classic styles. With this change, we won't need to change the code to use different theme styles on deployments.
@patitonar
Seems to work well, thank you.
Closes #190
I've added theming support to the Bridge UI.
Most or all of the existing elements are themeable, so it should be relatively easy to add support for new networks.
It's possible to start a new theme by doing:
new-theme-name
src/assets/stylesheets/themes/_core.scss
into a new file named_new-theme-name.scss
$theme-name: 'core';
to$theme-name: 'new-theme-name';
src/assets/images/themes/core
into a new folder namednew-theme-name
src/assets/stylesheets/application.scss
change@import "themes/core";
to@import "themes/new-theme-name";
_new-theme-name.scss
and thenew-theme-name
folder.Themes are generated at build time, it's not currently possible to change a theme dynamically.
This pull request is set to use the new 'Ethereum Classic network' theme. Both the original and new themes are available in
src/assets/stylesheets/application.scss
, lines 3 and 4.If you switch back to the
core
theme, it should look as it used to.The new theme should look something like this: