Closed patitonar closed 5 years ago
Deploy preview for kind-kilby-95344f processing.
Building with commit 86c1bfafbd781f5ea4f06a0d71545679e9de0fa2
https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9bbcaff76f4c0007f31e3e
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/stores/utils/contract.js | 1 | 12 | 8.33% | ||
src/stores/utils/web3.js | 0 | 19 | 0.0% | ||
<!-- | Total: | 1 | 31 | 3.23% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/components/ProgressRing.js | 1 | 0.0% | ||
src/components/utils/yn.js | 1 | 0.0% | ||
src/components/index.js | 1 | 0.0% | ||
src/App.js | 4 | 0.0% | ||
src/components/BridgeNetwork.js | 4 | 0.0% | ||
src/stores/utils/testUtils.js | 5 | 0.0% | ||
src/stores/utils/gas.js | 6 | 0.0% | ||
src/stores/utils/web3.js | 9 | 0.0% | ||
<!-- | Total: | 31 | --> |
Totals | |
---|---|
Change from base Build 385: | 5.9% |
Covered Lines: | 48 |
Relevant Lines: | 436 |
Instead of using
networkId
for detecting on which network the user is, now we usechainId
. For that I had to update to latest version ofweb3
since there is a newgetChainId
method. I could use raw request to get thechainId
for home and foreign networks, but I cannot access to the url used on the wallet, only by using the exposed web3 provider.For e2e tests I had to update the parity version. The e2e tests are failing, it seems an issue between the new web3 version we are using and the web3 version used by the metamask extension we are using on the test. I'll try to update the extension to a newer version.