search

omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

Web3 beta.50 issues #204

Closed patitonar closed 5 years ago

patitonar commented 5 years ago

As part of https://github.com/poanetwork/bridge-ui/pull/196 we upgraded web3 to version 1.0.0-beta.50.

The following issues need to be fixed:

  1. Ee2 tests are failing with error:

    Uncaught (in promise) TypeError: this.connection.on is not a function
at MetamaskProvider.registerEventListeners (web3-providers.umd.js:929)
at MetamaskProvider.AbstractSocketProvider (web3-providers.umd.js:135)
at new MetamaskProvider (web3-providers.umd.js:922)
at ProvidersModuleFactory.createMetamaskProvider (web3-providers.umd.js:1246)
at ProviderResolver.resolve (web3-providers.umd.js:57)
at Web3.AbstractWeb3Module (web3-core.umd.js:21)
at new Web3 (web3.umd.js:24)
at _callee$ (web3.js:24)
at tryCatch (runtime.js:62)
at Generator.invoke [as _invoke] (runtime.js:296)
at Generator.prototype.(:3000/anonymous function) [as next] (http://10.1.0.101:3000/static/js/bundle.js:93419:21)
at step (testUtils.js:21)
at testUtils.js:21
at new Promise (<anonymous>)
at testUtils.js:21

    This is possibly a error caused by the different versions of web3 used on the Metamask extension and the app. A solution could be to upgrade Metamask extension on the e2e tests.

  2. Error: Empty outputs array given! see this comment https://github.com/poanetwork/bridge-ui/pull/196#discussion_r269516877

  3. Error: Transaction has been reverted by the EVM even if transaction was successful. see this comment https://github.com/poanetwork/bridge-ui/pull/196#discussion_r269632458

akolotov commented 5 years ago

The issue is not applicable any more after migration back to web3js v1.0.0-beta.30