Closed patitonar closed 5 years ago
Deploy preview for kind-kilby-95344f processing.
Building with commit fe27eba69b51afe173103dd07c70ebdabcd047ee
https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9d2c416f5bc400088a6713
I refactored the solution. We go back to the initial 1.0.0-beta.30
version of web3 that used to work correctly. I added the modified version of web3-eth
that includes getChainId
on lib
folder. After installing dependencies, this file overrides the one installed on node_modules
.
I made more tests and with this changes and now the issue of false error of tx even if it was successful is now gone! So it seems that 1.0.0-beta.37
was causing that one too.
This PR add web3 library inside the repo on
lib
directory. This web3 version is based on1.0.0-beta.37
and includesgetChainId
method onweb3-eth
module.preinstall
script was added to correctly build and include the web3 library as dependency for the app.Closes https://github.com/poanetwork/bridge-ui/issues/204, using this version, we avoid the issues introduced before. While testing, only when I sent from ETC to ETH the false error of tx revert even if it was successful was present. So now we log the error but avoid stopping the UI flow