omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

Handling of absence eth_chainId on Web3 provider side #207

Closed akolotov closed 5 years ago

akolotov commented 5 years ago

If a web3 provider used by the wallet does not support eth_chainId call the message Wallet account rejected by user. You need to unlock your wallet. Please refresh the page and click 'Connect' button in your wallet popup appears. It does not clarify the issue.

That's why it is suggested to handle errors appeared when getChainId called and provide more precise explanation what it is necessary to do to address the issue.

netlify[bot] commented 5 years ago

Deploy preview for kind-kilby-95344f processing.

Building with commit 47c232a1195f4c1726e5dd5f69dd5e76c5be9e69

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9e01c79e88e3000864f322

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 438


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/utils/web3.js 0 3 0.0%
<!-- Total: 0 3 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/stores/utils/web3.js 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 436: -0.03%
Covered Lines: 48
Relevant Lines: 445

💛 - Coveralls