omni / bridge-ui

UI for TokenBridge, an interoperability solution between Ethereum networks for native and ERC tokens
https://bridge.poa.net/
41 stars 51 forks source link

Update contract submodule #220

Closed patitonar closed 5 years ago

patitonar commented 5 years ago

Updated contract submodule to version 2.3.1

netlify[bot] commented 5 years ago

Deploy preview for kind-kilby-95344f processing.

Building with commit 0ca3248cd6a3c71cc93e323fff1eaf9070d1e505

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5ce7ff5909a2470008ae3f5a

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 498


Totals Coverage Status
Change from base Build 488: 0.0%
Covered Lines: 122
Relevant Lines: 1436

💛 - Coveralls
akolotov commented 5 years ago

@patitonar e2e testing fails in the TravisCI:

npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/web3-providers-ws/websocket@git:/github.com/frozeman/WebSocket-Node.git#6c72925e3f8aaaea8dc8450f97627e85263999f2" as it does not contain a package.json file.
patitonar commented 5 years ago

Thanks @akolotov I'm reviewing the issue, it seems that a dependency is having some issues to be fetched. It also affects the PR on the oracle

akolotov commented 5 years ago

Thanks @akolotov I'm reviewing the issue, it seems that a dependency is having some issues to be fetched. It also affects the PR on the oracle

Arsenii Petrovich reported yesterday about the same issue in his experiments. He solved it by removing package.json in the contracts repository.