search

omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
79 stars 38 forks source link

Problem: slow performance and regular timeouts sending transactions #100

Closed yrashk closed 6 years ago

yrashk commented 6 years ago

Solution: fix the maximum number of concurrent HTTP request at a transport level.

It is set by default to 64 and there's now a new configuration parameter (concurrent_http_requests) in home and foreign sections. Previously used concurrency parameter from transactions configuration has been removed.

yrashk commented 6 years ago

Run 2000 deposits with and without it.

On Sun, Jun 3, 2018, 1:27 PM Alexander Kolotov notifications@github.com wrote:

@akolotov commented on this pull request.

@yrashk https://github.com/yrashk could you please advice how to check that this feature works?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/poanetwork/poa-bridge/pull/100#pullrequestreview-125407169, or mute the thread https://github.com/notifications/unsubscribe-auth/AAABxHCtNCoEV8rLpwO_m53nhh6ihgvaks5t5EaVgaJpZM4UXf3w .

akolotov commented 6 years ago

It is not clear for me what is expected?

-- Alexander Kolotov

On Sun, Jun 3, 2018 at 11:29 PM Yurii Rashkovskii notifications@github.com wrote:

Run 2000 deposits with and without it.

On Sun, Jun 3, 2018, 1:27 PM Alexander Kolotov notifications@github.com wrote:

@akolotov commented on this pull request.

@yrashk https://github.com/yrashk could you please advice how to check that this feature works?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/poanetwork/poa-bridge/pull/100#pullrequestreview-125407169 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAABxHCtNCoEV8rLpwO_m53nhh6ihgvaks5t5EaVgaJpZM4UXf3w

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/poanetwork/poa-bridge/pull/100#issuecomment-394189035, or mute the thread https://github.com/notifications/unsubscribe-auth/AT1HrNRllW4ZTvYWJVB6r64HnGW9XaLXks5t5Ec3gaJpZM4UXf3w .

yrashk commented 6 years ago

One will either take very long time or just timeout, the other will process them in a few seconds or so.

On Sun, Jun 3, 2018, 1:33 PM Alexander Kolotov notifications@github.com wrote:

It is not clear for me what is expected?

-- Alexander Kolotov

On Sun, Jun 3, 2018 at 11:29 PM Yurii Rashkovskii < notifications@github.com> wrote:

Run 2000 deposits with and without it.

On Sun, Jun 3, 2018, 1:27 PM Alexander Kolotov <notifications@github.com

wrote:

@akolotov commented on this pull request.

@yrashk https://github.com/yrashk could you please advice how to check that this feature works?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/poanetwork/poa-bridge/pull/100#pullrequestreview-125407169

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AAABxHCtNCoEV8rLpwO_m53nhh6ihgvaks5t5EaVgaJpZM4UXf3w

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/poanetwork/poa-bridge/pull/100#issuecomment-394189035>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AT1HrNRllW4ZTvYWJVB6r64HnGW9XaLXks5t5Ec3gaJpZM4UXf3w

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/poanetwork/poa-bridge/pull/100#issuecomment-394189270, or mute the thread https://github.com/notifications/unsubscribe-auth/AAABxENWVp6UZqEOEZLUpdrq-XilJM9sks5t5EgdgaJpZM4UXf3w .