search

omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
80 stars 38 forks source link

(Question) Should we have withdraws public ? #14

Closed rstormsf closed 6 years ago

rstormsf commented 6 years ago

https://github.com/poanetwork/parity-bridge/blob/master/contracts/bridge.sol#L165

@akolotov should we make it public?

akolotov commented 6 years ago

I do not think so. It uses a hash of the massage as a key. So, in order to get value from this map you need to take produce a message which contains recipient, withdraw value and tx id; then you need to get sha3() of this message and only after that call withdraws() to see if the message is handled properly. Since most often you will get the message from transaction which invoke withdraw(), you will always see if this transaction generated the event Withdraw which means that funds reached recipient.

@rstormsf your opinion?

akolotov commented 6 years ago

@rstormsf should we close it?

akolotov commented 6 years ago

We will not expose this map.

rstormsf commented 6 years ago

got it