omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
80 stars 38 forks source link

(NeedsDefinition) Define a name for POA ERC20 token #15

Closed rstormsf closed 6 years ago

rstormsf commented 6 years ago

https://github.com/poanetwork/parity-bridge/blob/master/contracts/bridge.sol#L267

    string public name = "ForeignBridge";

it will be shown on every DEX. we also need to add symbol = "POA" in order to follow ERC20 standard

I propose for "POA ERC20" as a name of the token

@akolotov, @igorbarinov thoughts?

igorbarinov commented 6 years ago

Я думал про POA20 для упрощения ПиОЭй Туени есть примеры использовация чисел в имени токена кстати?

igorbarinov commented 6 years ago

I meant POA20 Are there any examples of using numbers in a token name?

rstormsf commented 6 years ago

name doesn't matter, symbol is more important. Name could be "POA erc20 representation", etc. symbol should be short

https://coinmarketcap.com/currencies/firstblood/ = 1ST

image

https://etherscan.io/address/0xaf30d2a7e90d7dc361c8c4585e9bb7d2f6f15bc7#readContract

igorbarinov commented 6 years ago

Sure, I don't think it's good to have POA on POA and POA on Foundation because it's ambiguous POA20 will state that it is ERC20 compatible token. ERC now EIP. I suppose we can leave only the number which will identify the nature of token

rstormsf commented 6 years ago

ok, should we have

name = 'POA ERC20 Foundation'
symbol = 'POA20'

?

akolotov commented 6 years ago

The funny thing is that POA20 could be read as 'POA 2.0' :)

banteg commented 6 years ago

What about WPOA akin to WETH (wrapped ether)?

igorbarinov commented 6 years ago

didn't know about weth more info https://weth.io/

igorbarinov commented 6 years ago

I like

akolotov commented 6 years ago

@rstormsf should we close it?

igorbarinov commented 6 years ago

I'd like to add on

name = 'POA ERC20 on Foundation'
symbol = 'POA20'

I'm fine with it

akolotov commented 6 years ago

So, @rstormsf please close this issue as soon as you update the contract in https://github.com/poanetwork/poa-parity-bridge-contracts

igorbarinov commented 6 years ago

@akolotov he'll assing it to himself in Waffle and move to bottom so we'll know it's less important

akolotov commented 6 years ago

@rstormsf could we have a final tool/script/whaterver in the repo which will be used to deploy token contract. The name and symbol of the token will be specified there as so we can manage it through source control system.

rstormsf commented 6 years ago

? @akolotov it's just a contract with parameters...what do you want? https://github.com/poanetwork/poa-parity-bridge-contracts/blob/upgradable/migrations/3_upgradeable_deployment.js#L19