omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
80 stars 38 forks source link

Withdraw does not work after introduction of MessageToMainnet #23

Closed akolotov closed 6 years ago

akolotov commented 6 years ago

Previously messages appeared as part of Withdraw event in ForeignBridge contract were put as is into the map messages. When the new module MessageToMainnet was introduced some integer values from messages were presented with little endian encoding. This causes bug in handling value and homeGasPrice on HomeBridge side and final transfer of funds cannot be completed.

Investigation is required to understand if it is necessary to use little endian encoding at all.

As soon as the issue is fixed changes to withdraw() of HomeBridge contract need to be applied to remove the workaround.

akolotov commented 6 years ago

Fixed