search

omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
80 stars 39 forks source link

Problem: main development branch is obscurely named #31

Closed yrashk closed 6 years ago

yrashk commented 6 years ago

poa-dev-2 is not the most obvious place to look for.

Proposed solution: merge it into master.

igorbarinov commented 6 years ago

Good idea to keep master in master. Should we remove forked repo and recreate it without the link to upstream?

yrashk commented 6 years ago

That's rather a cosmetical decision to make. Either is fine.

rstormsf commented 6 years ago

👍

yrashk commented 6 years ago

Any objections to this one?

rstormsf commented 6 years ago

@yrashk zero

akolotov commented 6 years ago

@yrashk I am waiting for response from @igorbarinov

yrashk commented 6 years ago

It is an entirely reversible decision, actually. Up to a point, that is.

akolotov commented 6 years ago

I understand this. There is no rush with switching the branch - I do not see how it blocks resolving of any other issues we have.

yrashk commented 6 years ago

It only blocks in a sense that if I will be sending pull requests to poa-dev-2 for now I'd need to update this PR, too. to include those, post-merge.

akolotov commented 6 years ago

That's why my suggestion is to discuss such kind of proposal before doing actual PR. I like a process when we open an issue, discuss it and implement changes as per discussion.

akolotov commented 6 years ago

Discussed the branch swapping with Igor. We will switch our main branch to master.