omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
80 stars 38 forks source link

(Feature) Make bridge contract upgradable #7

Closed rstormsf closed 6 years ago

rstormsf commented 6 years ago

ZepplinOs and Aragon presented new way to write smart contract so you can separate the storage and implementation. https://github.com/zeppelinos/labs I personally like eternal storage with registry of contracts

akolotov commented 6 years ago

I would be very accurate with the ability to upgrade smart contracts. Yes, it is great opportunity to provide fixes and extend the functionality of contracts. But from another side, it means that the contract can change behavior and it will not be the same as user agreed initially when started using the contract. Imagine that initially the bridge contract relayed confirmations and after upgrade started taking some fee for this. There is no simple way to inform users about changes so that's why personally I think twice prior to delegate controlling of my money to upgradable contract.

It is the same as "the Bank has the right to unilaterally change the list of ..." in real life.

rstormsf commented 6 years ago

done.