search

omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead
https://github.com/poanetwork/token-bridge
GNU General Public License v3.0
79 stars 38 forks source link

Problem: errors do not show their context #76

Closed yrashk closed 6 years ago

yrashk commented 6 years ago

If the error like this appears in the logs:

INFO:bridge::bridge::withdraw_confirm: waiting for new withdraws that
should get signed
WARN:bridge: Bridge crashed with Error(Transport("Incomplete"), State {
next_error: None, backtrace: None })
Error(Transport("Incomplete"), State { next_error: None, backtrace: None
})

it is hard to understand which side of the bridge failed. The message must contains type of operation (deposit_relay, withdraw_confirm or withdraw_relay) and side of bridge (URL of RPC channel).

Solution: record error's top level context and print it out if recorded

Addresses #75

akolotov commented 6 years ago

Do not see any other obvious issues. Approve.