Added home and foreign gas price retrieval from oracle URL.

omni / poa-bridge

POA <-> Ethereum bridge for self transfers of POA native token to POA20 (ERC20 representation). Not supported. Use TokenBridge instead

https://github.com/poanetwork/token-bridge

GNU General Public License v3.0

79 stars 38 forks source link

Added home and foreign gas price retrieval from oracle URL. #80

Closed DrPeterVanNostrand closed 6 years ago

DrPeterVanNostrand commented 6 years ago

Added TOML config options for home and foreign: gas price oracle url, oracle request timeout, and default gas price.
Created struct GasPriceClient to hold http clients for querying the home and foreign gas price oracles.
Added a gas_prices: Arc<Mutex<GasPriceClient>> field to the App.
Added home gas price oracle querying for: withdraw_relay.
Added foreign gas price oracle querying for: withdraw_confirm and deposit_relay.

DrPeterVanNostrand commented 6 years ago

Ok that makes sense, I can remove the formatting changes.
I've never seen that style of commit before, but I do aprecaite it. I am probably going to start a new branch for rewriting this PR, using hyper and streams, I will use that commit style.
I originally tried this issue using hyper and streams, but I had a rough time getting it to work (It was basically my first time using hyper and tokio), I'll start a new branch and try to get GasPriceClient working as a Stream.

yrashk commented 6 years ago

Re 3. Futures and Streams are not always most straightforward to think/reason about, so I will be happy to give a hand if necessary to make this happen.

yrashk commented 6 years ago

@DrPeterVanNostrand do you need help with futures/streams?