Extend tracebility of deposits transactions

akolotov commented 6 years ago

Currently every bridge instance sends deposit() to the Foreign side to confirm transfer of funds. But only transaction which allow to reach requiredSignatures limit generates an event.

Proposal for changes

In order to simplify issues investigation process it makes sense to generate events on every unique and valid depost() transactions.

The suggestion is to raise SignedForDeposit(address indexed, bytes32) with the bridge address and id of the transaction originating deposit request on the Home (left) side:

the brigde address will allow to filter transactions from the specific bridge;
the tx id will allow to match the transaction on the Home side and bridge resposes on the Foreign side.

Prior to merge of these changes it is necessary to understand how gas consumption is being increased and get agreement that it is acceptable.

rstormsf commented 6 years ago

I support this idea. Can you specify which method should fire this event? @akolotov I assume deposit() on ForeignBridge and same for transferAndCall

akolotov commented 6 years ago

Yes. it needs to be implemented in deposit() of ForeignBridge.
transferAndCall() will generate Withdraw() event similar to transferHomeViaRelay (https://github.com/poanetwork/parity-bridge/blob/master/contracts/bridge.sol#L423-L436).
but you are right it makes sense to implement SignedForWithdraw(address indexed, bytes32) in submitSignature().

omni / poa-bridge

Extend tracebility of deposits transactions #9