Closed jeroenheijmans closed 8 years ago
Actually, it makes sense to leave it on the concrete CheckResult
class, making it easier for others to use the class (e.g. create an instance first, and assign the actual level later). But as for the interface: it's really not needed, and if it's removed implementations with read-only versions of those properties will also be possible.
Both
ICheckResult
and (obiviously)CheckResult
have setters for these properties:and
We found while dogfooding that it often makes sense to have an implementation of
ICheckResult
that does not have such a setter for e.g. theLevel
, because it's a read-only / derived property. There was no sensible or useful implementation for the setter.In addition, currently these setters aren't used anywhere in Nimator itself either.
So, we might as well get rid of these setters.