omniauth / omniauth-saml

A generic SAML strategy for OmniAuth
https://github.com/omniauth/omniauth-saml
Other
331 stars 205 forks source link

Rename usage of deprecated SAML options #206

Closed MrSerth closed 2 years ago

MrSerth commented 2 years ago

I started using the omniauth-saml gem a few days ago. While implementing SSO and SLO functionality, I noticed a discrepancy between the settings of the current ruby-saml gem and this gem. This MR is intended to fix these:

Deprecations

While I would recommend all usages of this gem to update the settings, these changes should be backward compatible: Ruby-SAML has built-in support for using the new names to query information set with the deprecated methods:

MrSerth commented 2 years ago

Sorry to ping you, @bufferoverflow and @suprnova32, directly. I just wanted to ask for feedback for my PR and would appreciate if you could have a look to potentially merge these changes and release a new version of the gem. Thanks a lot for your time and please excuse reaching out to you.

bufferoverflow commented 2 years ago

looks good to me but we miss CI at the moment here. I prefer to have this in place before doing any merge.

suprnova32 commented 2 years ago

@MrSerth I set up GitHub Actions for CI just now. If you rebase your changes against master we should see the tests running for your branch as well.

suprnova32 commented 2 years ago

v2.1.0 has been pushed to include these changes

MrSerth commented 2 years ago

Awesome, thank you for introducing the CI and pushing a new release! 👏