Closed MrSerth closed 2 years ago
Sorry to ping you, @bufferoverflow and @suprnova32, directly. I just wanted to ask for feedback for my PR and would appreciate if you could have a look to potentially merge these changes and release a new version of the gem. Thanks a lot for your time and please excuse reaching out to you.
looks good to me but we miss CI at the moment here. I prefer to have this in place before doing any merge.
@MrSerth I set up GitHub Actions for CI just now. If you rebase your changes against master we should see the tests running for your branch as well.
v2.1.0 has been pushed to include these changes
Awesome, thank you for introducing the CI and pushing a new release! 👏
I started using the
omniauth-saml
gem a few days ago. While implementing SSO and SLO functionality, I noticed a discrepancy between the settings of the currentruby-saml
gem and this gem. This MR is intended to fix these:Deprecations
settings.issuer
has been renamed tosettings.sp_entity_id
withruby-saml
1.11.0settings.idp_sso_target_url
has been renamed tosettings.idp_sso_service_url
withruby-saml
1.12.0settings.idp_slo_target_url
has been renamed tosettings.idp_slo_service_url
withruby-saml
1.12.0While I would recommend all usages of this gem to update the settings, these changes should be backward compatible: Ruby-SAML has built-in support for using the new names to query information set with the deprecated methods:
settings.sp_entity_id
might return the value ofsettings.issuer
settings.idp_sso_service_url
might return the value ofsettings.idp_sso_target_url
settings.idp_slo_service_url
might return the value ofsettings.idp_slo_target_url