omniauth / omniauth_openid_connect

MIT License
170 stars 187 forks source link

Upgrade Faker and replace Travis with Github Actions #102

Closed davidwessman closed 2 years ago

davidwessman commented 2 years ago

Running on my own PR https://github.com/davidwessman/omniauth_openid_connect/pull/1

Could not get the tests to run for Ruby 3.1, missing net/smtp.

davidwessman commented 2 years ago

How about maybe also adding JUnit output for tests and feeding it into https://github.com/marketplace/actions/junit-report-action? (Iā€™m not quite sure how to do this for Ruby, but StackOverflow seems to have some solutions.)

I can look into it in a separate PR šŸ˜Š

davidwessman commented 2 years ago

Can someone allow the checks to run if you think it looks good? Who can merge it?

davidwessman commented 2 years ago

@andrewshadura I updated the on: tag of the Github Action workflow to avoid duplicate jobs.

andrewshadura commented 2 years ago

I guess you need to ask actual maintainers to have a look šŸ™‚

davidwessman commented 2 years ago

@Eric-Guo @m0n9oose Can you take a look? Who else are maintainers?

bufferoverflow commented 2 years ago

/cc @stanhu