search

omniauth / omniauth_openid_connect

MIT License
171 stars 187 forks source link

Try to fix https://coveralls.io/ in WIP #108

Closed Eric-Guo closed 2 years ago

Eric-Guo commented 2 years ago

https://coveralls.io/github/omniauth/omniauth_openid_connect

Eric-Guo commented 2 years ago

Seems break in CI after #102, but in my local dev, at least can submit the cover data via API, although wrong percent cover.

@davidwessman any idea? not sure coveralls is binding to Travis only or not...

davidwessman commented 2 years ago

@Eric-Guo I think we should add it as an explicit Github Action step, then we can use the repository secrets instead. https://github.com/marketplace/actions/coveralls-github-action#complete-parallel-job-example

davidwessman commented 2 years ago

https://github.com/omniauth/omniauth_openid_connect/pull/109 @Eric-Guo Please check out my suggestion 🙂