search

omniauth / omniauth_openid_connect

MIT License
168 stars 187 forks source link

Fetch key from JWKS URI if available #133

Closed stanhu closed 1 year ago

stanhu commented 1 year ago

In non-standard OpenID Connect providers, such as Azure B2C, discovery does not work because the discovery URL does not match the issuer field. If a JWKS URI is provided when discovery is disabled, we should make an HTTP request for the keys and use the response.

Closes https://github.com/m0n9oose/omniauth_openid_connect/issues/72

This is part of the effort to upstream changes in the GitLab fork: https://gitlab.com/gitlab-org/ruby/gems/gitlab-omniauth-openid-connect/-/issues/5.

stanhu commented 1 year ago

@jessieay @bufferoverflow Could you review this?

bufferoverflow commented 1 year ago

@azure Is this correct ? Azure B2C, discovery does not work because the discovery URL does not match the issuer field and therefore being non-standard OpenID Connect?

stanhu commented 1 year ago

@bufferoverflow FYI, the Azure non-compliance has been discussed in other issues:

  1. https://github.com/MicrosoftDocs/azure-docs/issues/38427
  2. https://github.com/coreos/go-oidc/issues/344