omniauth / omniauth_openid_connect

MIT License
170 stars 187 forks source link

Update openid_connect to 2.2 #153

Closed takahashim closed 1 year ago

takahashim commented 1 year ago

I am trying to use omniauth_openid_connect in a service using the apple_id gem. However, it seems that the version of openid_connect that omniauth_openid_connect depends on is outdated, making it impossible to install with the version of the apple_id gem we are using. So, I would like to make omniauth_openid_connect compatible with the newer version of openid_connect.

davidwessman commented 1 year ago

The changes in openid_connect seems to match very well with your changes, looks good to me 🙂

stanhu commented 1 year ago

Dropped Ruby 2.5 and 2.6 CI support in https://github.com/omniauth/omniauth_openid_connect/pull/154.

takahashim commented 1 year ago

Thank you for merging!

raivil commented 1 year ago

@takahashim Found this possible issue with the update. https://github.com/omniauth/omniauth_openid_connect/issues/156 Can you check it out?

takahashim commented 1 year ago

@raivil Thank you for notifying me. I will check it later.