search

omniauth / omniauth_openid_connect

MIT License
168 stars 187 forks source link

Migration guide from gitlab-omniauth-openid-connect to this gem? #165

Closed ThisIsMissEm closed 10 months ago

ThisIsMissEm commented 10 months ago

Hi! It's great to see that you're continuing the maintenance of the omniauth openid connect strategy, I'm just wondering if there's any notes on migrating between the two that could be shared? Is this a drop-in replacement for gitlab-omniauth-openid-connect or would one have to make code changes?

bufferoverflow commented 10 months ago

yes, all changes should have been merged here, see also https://gitlab.com/gitlab-org/ruby/gems/gitlab-omniauth-openid-connect

stanhu commented 10 months ago

Is this a drop-in replacement for gitlab-omniauth-openid-connect or would one have to make code changes?

Yes, I believe so. GitLab transitioned from this gem to v0.6.1 without any changes.

stanhu commented 10 months ago

The same goes for Mastodon: https://github.com/mastodon/mastodon/pull/23223

ThisIsMissEm commented 10 months ago

The same goes for Mastodon: mastodon/mastodon#23223

Ha, something must've gone wrong in my local checkout, I'd seen the old gem in my copy of the code, hence opening this as I thought it hadn't been done 🤦🏻‍♀️😅