Add `audience` to the `client_options`

omniauth / omniauth_openid_connect

MIT License

168 stars 187 forks source link

Add `audience` to the `client_options` #179

Closed manuelvanrijn closed 3 months ago

manuelvanrijn commented 4 months ago

I've come across an issue where the identifier wasn't equal to the audience in the token. This resulted in verification errors because currently it will verify the aud against the identifier if no audience is specified.

In this PR, I introduced the audience as client_options and will pass this along in the verify! of the decoded_id_token so the openid_connect gem can handle the expected audience

manuelvanrijn commented 4 months ago

@stanhu @bufferoverflow just a friendly ping 😄 Would you have time to review this ? Thanks in advance!

stanhu commented 3 months ago

There are also Rubocop failures: https://github.com/omniauth/omniauth_openid_connect/actions/runs/9779345570/job/27001862614?pr=179