search

omniauth / omniauth_openid_connect

MIT License
170 stars 187 forks source link

Use !!match rather than match? for Regexp in Rubies before 2.4 #45

Closed Capncavedan closed 5 years ago

Capncavedan commented 5 years ago

Regexp#match? was introduced in ruby 2.4; this change will maintain compatibility with older rubies like 2.3.

m0n9oose commented 5 years ago

Hey @Capncavedan

Thanks a lot for your time!

Sorry, but I don’t see why we need this after all this time.

Especially considering the fact that ruby ​​2.3 has reached the end-of-life stage https://www.ruby-lang.org/en/downloads/branches/

Capncavedan commented 5 years ago

@m0n9oose I can understand your position; this seems like a straightforward change, though.

Perhaps a note at the top of the README indicating only 2.4+ is supported would be in order.