omniauth / omniauth_openid_connect

MIT License
171 stars 187 forks source link

solved KidNotFound error during signature verification #68

Closed TheTesla closed 3 years ago

TheTesla commented 4 years ago

This is a temporary fix. We will reintroduce signature verification without kid later.

TheTesla commented 4 years ago

The problem was only the type of the key. It was given as a set or list. In this case kid is needed to select the corresponding key. But we have only one key given and no kid defined in the jwt. So we can convert the set/list of key to one key by selecting the first and only before giving it to the function.

gcolson commented 4 years ago

I had the same issue and tested with the first commit a43dd23 : it didn't work better for me. e2e529e seem to fix the issue for me but, as you say, a way to reintroduce signature verification need to be found..

TheTesla commented 4 years ago

I had the same issue and tested with the first commit a43dd23 : it didn't work better for me. e2e529e seem to fix the issue for me but, as you say, a way to reintroduce signature verification need to be found..

So maybe the key is missing entirely for you. Please, post the error message.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stanhu commented 3 years ago

I believe https://github.com/nov/json-jwt/pull/92 is the proper fix for this issue.