search

omniauth / omniauth_openid_connect

MIT License
170 stars 187 forks source link

Support for multiple response types #83

Closed tgunaselan closed 3 years ago

tgunaselan commented 3 years ago

Currently, response_type can be either code or id_token.

Does this gem have support for multiple-valued response types, such as id_token token?

If so, what is the correct format for specifying them in the config? If not, can this functionality be added?

See the following for references:

https://openid.net/specs/openid-connect-core-1_0.html#Authentication

tgunaselan commented 3 years ago

For implicit and hybrid flow, enabling "token" along with code/id_token would be much helpful

tgunaselan commented 3 years ago

Any Update.

tgunaselan commented 3 years ago

Hello, Is this request need any further reasons or inputs from my end ?

tgunaselan commented 3 years ago

Pinging here to enable this request open.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gwright commented 3 years ago

I'd like to reopen this topic. I'm looking to implement the hybrid flow ("code id_token") and that fails with the current version of the gem the #valid_response_type? method because it assumes a single configured value for response_type. I'm not sure if that is the only difficulty but I'm going to see if I can get this to work in a fork.

kreintjes commented 8 months ago

Same problem over here. Our provider recommends the hybrid flow ("code id_token") in our situation. We cannot currently achieve this with this gem. Is there any solution for this or are there plans to implement this?

davidwessman commented 8 months ago

I do not think anyone is working actively unless it is for their own usage. So please try to make a PR 🙂

davidwessman commented 8 months ago

I guess this is what you are looking for? https://github.com/omniauth/omniauth_openid_connect/pull/139

Maybe try it out, see if it works for you?

kreintjes commented 8 months ago

Ah nice, missed that one. Good thing it is mentioned here now. Thanks!