Closed LorenzoMerotto closed 2 years ago
Two more things we need to think of:
Could you please check the licenses of the methods, similar to this table? We need to be careful when including GPL-licensed code directly in the package and we'll need to update that table anyway.
We'll need to take care of the dependency management. The package has already (too) many dependencies, and I'm a bit wary including more. Maybe the new packages should become optional dependencies, as Konstantin implemented it for omnideconv. Also all dependencies must be available on bioconda. If they are not, we'll need to add them. Could you maybe list the links to all packages and check which methods are already available from bioconda?
In terms of External Dependencies we need to add:
Licenses
mMCPcounter: GP-3.0
seqImmuCC (requires CIBERSORT): CIBERSORT is free for non commercial use, and I am waiting for the authors to confirm the license for the rest
DCQ (ComICS package): GPL-2.0
BASE: not specified (source code is attached to the published paper)
ABIS: GPL-2.0
ConsensusTME: GPL-3.0
Datasets Some datasets should be included in the package as well.
Update from the authors: for the BASE algorithm there is no license so we can use it how we want
Did they say that we can use it specifically? As I understand it, no license means technically you can not use it at all.
@mlist "There is no license for BASE. Feel free to incorporate into your package." This is what they said. They probably meant that there was no particular restriction
Ok then :)
@LorenzoMerotto, I thin you addressed all of this in #81? Feel free to close the issue!
1) MOUSE deconvolution Each function will return the results in the way they are given by the tool/algorithm
Files to be included:
2) HUMAN deconvolution