search

omnidevZero / YouTubeRedux

Browser extension that focuses on restoring old YouTube layout within Polymer design (modern layout).
175 stars 11 forks source link

Disable Miniplayer selection only partially works. #109

Open Amariithynar opened 1 year ago

Amariithynar commented 1 year ago

It hides the window, but the video is still playing. You keep getting the audio after clicking off of a video (why was this ever a thing, Youtube?! It's so goddamn stupid!).

omnidevZero commented 1 year ago

I couldn't reproduce it. Which browser are you using?

Amariithynar commented 1 year ago

Firefox. Version 107.0, aka up-to-date. It doesn't happen all the time, and the miniplayer button is disabled while it's also disabled (edit:in the options menu), but if you go to say, subscriptions while watching a video, it sometimes puts the video (edit:that is currently actively playing) into miniplayer. With it (edit: the option to disable miniplayer) active, it disables the video frame that would appear, but the video itself keeps playing, and you get the audio from it, until you click onto another video or refresh the page.

LautaroL20 commented 1 year ago

This issue happens to me too, I could record a video showing the issue if needed.

omnidevZero commented 1 year ago

but if you go to say, subscriptions while watching a video

Oh right, that's the case! Going from video page to subscriptions I was able to easily reproduce it. The issue was that I was testing it by going back to the homepage and that's also how the extension works - it checks if the user is on the homepage and then closes the miniplayer. Anyway, I removed the condition that checked for the specific page, will be fixed in the next update, thanks!