p2p communication data should be strongly typed

omnilaboratory / obd

OmniBOLT daemon, a golang implementation of OmniBOLT spec, the smart assets lightning network.

MIT License

213 stars 21 forks source link

p2p communication data should be strongly typed #49

Open wxf4150 opened 2 years ago

wxf4150 commented 2 years ago

The data type of p2p communication is not strongly typed. At present, using one ~ char to split the data stream, using gjson to extract json data is not safe enough; it should be possible to use protobuf to do complete and strongly typed data extraction. The data stream separator should be longer to reduce potential segmentation errors, maybe three '~' char will better.

neocarmack commented 2 years ago

yes. It is a problem. We are now integrating with the latest omnicore, this issue should be fixed accordingly.