omnilight / yii2-scheduling

Scheduling extension for Yii2 framework
MIT License
317 stars 84 forks source link

Add library tests #29

Open omnilight opened 6 years ago

omnilight commented 6 years ago

We need to have tests for the all of the library code.

Also that should be integrated with travisci

kievo23 commented 6 years ago

command like tests?

kstkn commented 6 years ago

As in the first place this package is a port of Laravel's Scheduler, may be good point would be to check their tests:

https://github.com/laravel/framework/blob/master/tests/Console/ConsoleEventSchedulerTest.php https://github.com/laravel/framework/blob/master/tests/Console/Scheduling/EventTest.php https://github.com/laravel/framework/blob/master/tests/Console/Scheduling/CacheSchedulingMutexTest.php

kstkn commented 6 years ago

@omnilight please, take a look at https://github.com/omnilight/yii2-scheduling/pull/31, we can use this approach to port Laravel's tests

omnilight commented 6 years ago

For me - looks good

kstkn commented 6 years ago

Merged #31, will you now integrate travis, @omnilight?

omnilight commented 6 years ago

Let's do it

kstkn commented 6 years ago

@omnilight, I think only you able to do it as owner: https://github.com/marketplace/travis-ci

kstkn commented 5 years ago

@omnilight yup, I can add only my own repos to travis: 2019-04-09_23-13