search

omnilight / yii2-scheduling

Scheduling extension for Yii2 framework
MIT License
315 stars 83 forks source link

Use another package cron-expression #54

Closed hirenbhut93 closed 4 years ago

hirenbhut93 commented 4 years ago

Resolved #52

kstkn commented 4 years ago

dragonmantank/cron-expression v2 will require php v7. We should use older version, latest supporting php 5 I can see is v1.2.1

JimChenWYU commented 4 years ago

Or we should also release 2.0 for dragonmantank/cron-expression v2 ?

kstkn commented 4 years ago

That is a great idea @JimChenWYU and of course we should do that, but in separate issue since there's stuff to do: to check other packages dependencies and to check code compatibility

JimChenWYU commented 4 years ago

@gietos I suggest to use this tools to check our code when upgrade from php5 to php7, it'is too convenient. : )

  1. https://github.com/sstalle/php7cc
  2. https://github.com/phan/phan
  3. https://github.com/phpstan/phpstan
kstkn commented 4 years ago

Thanks for your suggestions @JimChenWYU, yet I'd move this conversation into a separate issue and keep this thread for pull request discussion

theonedemon commented 4 years ago

up?

kstkn commented 4 years ago

Closing this for now. Will create separate PR to switch to the version of the library that supports php v5.*

kstkn commented 4 years ago

https://github.com/omnilight/yii2-scheduling/pull/56